Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make debugger class configurable #1307

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

smacke
Copy link
Contributor

@smacke smacke commented Dec 13, 2024

In this PR, add fields compiler_class and debugger_class defaulting to the normal types. Kernel subclasses can override these to provide additional customizations.

Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! In full disclosure, we'd like this at Databricks (where Stephen and I both work) because we customize the debugger class.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309

@jasongrout
Copy link
Member

It seems fine, but not 100% sure as I get an error when trying to install kernel: #1309

Following up here for completeness, it seems like David fixes this error in #1310

@Carreau
Copy link
Member

Carreau commented Feb 11, 2025

Can this get rebased to trigger CI (I try to do it, but there is no allow push from maintainers).

@smacke smacke force-pushed the smacke/configurable-debugger branch from 6bd5782 to 175f1dc Compare February 11, 2025 23:33
@smacke
Copy link
Contributor Author

smacke commented Feb 11, 2025

Hey @Carreau just rebased + pushed

@Carreau
Copy link
Member

Carreau commented Feb 12, 2025

There is one minor lint to fix (unused mypy ignore), and I restarted the test on 3.9.

I would actually be in favor of dropping 3.9 support (per https://scientific-python.org/specs/spec-0000/), and FYI IPython CLI already dropped 3.10.

@smacke
Copy link
Contributor Author

smacke commented Feb 14, 2025

@Carreau did you want me to fix those lint failures? They don't seem related with this change but happy to do it anyway

@Carreau
Copy link
Member

Carreau commented Feb 14, 2025

No, it was just a "the failures are know and fixed on master". I haven't been involved in ipykernel in a while and was reluctant to merge, but I think that's ok.

@Carreau Carreau merged commit 3867c33 into ipython:main Feb 14, 2025
26 of 32 checks passed
@Carreau Carreau added this to the 7.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants