Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Skip unregistering comm with destructor. #433

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

impact27
Copy link
Contributor

The comm can not still be registered when __del__ is being called:

  • if __del__ is called, the reference count is at 0.
  • if the reference count is at 0, then the comm manager doesn't have a reference to the comm.

This avoids spyder-ide/spyder-kernels#145

@impact27 impact27 changed the title remove comm __del__ method PR: Skip unregistering comm with destructor. Sep 14, 2019
@ccordoba12
Copy link
Member

@blink1073, could you take a look at this one? We need it for the next major release of Spyder, which we're trying to get out of the door in a month or so.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 9de554f into ipython:master Sep 14, 2019
@ccordoba12 ccordoba12 mentioned this pull request Sep 14, 2019
@ccordoba12
Copy link
Member

Thanks a lot @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants