Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't enter None eventloop #464

Merged
merged 2 commits into from
Mar 17, 2020
Merged

PR: Don't enter None eventloop #464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
938f2c7
Fix None eventloop
Dec 4, 2019
a5fa568
Add blank line around nested function
Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ipykernel/kernelbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,10 @@ def enter_eventloop(self):
self.log.info("Entering eventloop %s", self.eventloop)
# record handle, so we can check when this changes
eventloop = self.eventloop
if eventloop is None:
self.log.info("Exiting as there is no eventloop")
return

def advance_eventloop():
# check if eventloop changed:
if self.eventloop is not eventloop:
Expand Down