Produce better traceback when kernel is interrupted #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ful diagnostic message.
|
Could you post screenshots of the before and after behaviors? |
|
Before: After: For comparison, an extension that I'm working on: |
|
Wow! This is a great improvement, thanks! |
|
Cool. I see that this affects Spyder as well. IPython in bare terminal doesn't run that code but produces a neat traceback (no internals, just user code) by default. |
|
Yeah, it'll be a very neat improvement in both the notebook and Spyder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code no longer worked as intended because modern Python versions require
from Noneto suppress the previous context, and as a result a long traceback of ipykernel internals was being printed when pressing the Stop button.This PR fixes the suppression and adds a debug message to make it easier to it easier to understand what happened.