Add configure_inline_support and call it in the shell #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
add_configure_inline_support
branch
2 times, most recently
from
23a5966
to
f2159e0
Compare
This removes a circular dependency between ipykernel and IPython.
martinRenou
force-pushed
the
add_configure_inline_support
branch
from
f2159e0
to
3e69ce7
Compare
|
Thanks for merging @blink1073 I need to check that this works properly with the current IPython version. I've only tested it coupled with ipython/ipython#12814. Sorry, this should have been a draft PR :S |
|
Thanks for the heads up! I'll make sure not to cut any releases until then. |
|
Looks like it works properly 👍🏼 It will configure the inline backend twice, but I guess we can live with that until IPython removes it. |
|
Great, thanks for following up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a circular dependency between ipykernel and IPython. See ipython/ipython#12814