Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush control stream upon shutdown #611

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Flush control stream upon shutdown #611

merged 1 commit into from
Mar 22, 2021

Conversation

SylvainCorlay
Copy link
Member

The control stream was not properly flushed before shutting down the ZMQ context.

This fixes CI in jupyter_client with the pre-release.

blink1073
blink1073 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@blink1073 blink1073 added this to the 6.0 milestone Mar 22, 2021
@blink1073 blink1073 merged commit 32e6e9c into ipython:master Mar 22, 2021
@SylvainCorlay SylvainCorlay deleted the flush-control-upon-shutdown branch March 22, 2021 13:16
@blink1073 blink1073 added the bug label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SylvainCorlay @blink1073 @JohanMabille