Keep preferring SelectorEventLoop on Windows #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selector is preferable when ~all out events are on zmq sockets, which uses the unsupported add_reader methods. Tornado 6.1 puts these events in a background thread when Proactor is used, which we can avoid by using Selector.
|
@meeseeksdev please backport to 5.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipykernel
that referenced
this pull request
May 13, 2021
blink1073
added a commit
that referenced
this pull request
May 13, 2021
…on-5.5.x Backport PR #669 on branch 5.5.x (Keep preferring SelectorEventLoop on Windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selector is still preferable when ~all out events are on zmq sockets, which must use the add_reader methods missing from Proactor. Tornado 6.1 puts these events in a background thread when Proactor is used, which we can avoid by using Selector.
cf jupyter/notebook#6052
reverts that part of #564
I don't understand the hang mentioned in #563 - if/where that happens and is caused by this patch, it is presumably multiple event loops with events, but only one running (waiting on async events scheduled on a non-running loop will never finish). That should be traceable and avoidable, though, if it can be reproduced.