Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tk and asyncio event loops #704

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix Tk and asyncio event loops #704

merged 1 commit into from
Jul 1, 2021

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jul 1, 2021 •
edited
Loading

I noticed this when running the Spyder test suite against the newly released ipykernel 6.

@ccordoba12 ccordoba12 mentioned this pull request Jul 1, 2021
Merged
@Carreau Carreau added this to the 6.0 milestone Jul 1, 2021
@Carreau
Copy link
Member

Carreau commented Jul 1, 2021

Thanks, we'll likely do a 6.0.1 soon, and this kind of things should really be caught by something like flake8 in CI.

This was referenced Jul 1, 2021
Open
Merged
@Carreau Carreau modified the milestones: 6.0, 6.0.1 Jul 1, 2021
@blink1073 blink1073 added the bug label Jul 1, 2021
blink1073
blink1073 approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 0d59200 into ipython:master Jul 1, 2021
@ccordoba12 ccordoba12 deleted the fix-eventloops branch July 1, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ccordoba12 @Carreau @blink1073