Make json_clean a no-op for jupyter-client >= 7

[martinRenou]

Fix #706

This should not be merged before a potential release of jupyter_client with jupyter/jupyter_client#664, otherwise, Matplotlib will not work anymore in Jupyter Notebook/Lab

[JohanMabille]

Please notice that this function is also used by the debugger and this PR would break the richInspect feature. It should be fixed before merging this.

[martinRenou]

Thanks for the review @JohanMabille. I hadn't rebased.

[martinRenou]

This should be resolved now. Testing message dumps as jupyter_client does it.

[minrk]

👍 to the change in general. Can we get matplotlib working? Or can it not be done here because the mpl backend was moved to its own package?

What about including a backport of the json_default function from jupyter/jupyter_client#664?

[martinRenou]

Thanks a lot for your review @minrk !

Can we get matplotlib working?

This needs jupyter/jupyter_client#664 which does the base64 serializing https://github.com/jupyter/jupyter_client/pull/664/files#diff-fda072ac1fb480ce6ce75694ef6e4144e811d8443191be1c4f233a9ee3fd02a1R108

I am not sure we can fix it here, as ipykernel is not responsible for the serialization.

What about including a backport of the json_default function from jupyter/jupyter_client#664?

You mean here in ipykernel?

[martinRenou]

This requires jupyter_client>=7, I've updated the requirement in setup.py accordingly

I made the json_clean function a no-op only when jupyter_client>=7

[blink1073]

Thank you!

[martinRenou]

Thanks!!