Fix typo in eventloops.py #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo in eventloops.py : Changing kernel_shell_stream to kernel.shell_stream fixes this NameError with the MacOSX backend
Using matplotlib backend: MacOSX
ERROR:tornado.application:Exception in callback functools.partial(<function Kernel.enter_eventloop.<locals>.advance_eventloop at 0x108aefe50>)
Traceback (most recent call last):
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/tornado/ioloop.py", line 741, in _run_callback
ret = callback()
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/ipykernel/kernelbase.py", line 401, in advance_eventloop
eventloop(self)
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/ipykernel/eventloops.py", line 327, in loop_cocoa
if kernel_shell_stream.flush(limit=1):
NameError: name 'kernel_shell_stream' is not defined
Carreau
approved these changes
Jul 6, 2021
beaveis
reviewed
Jul 7, 2021
There was a problem hiding this comment.
missing kernel is the only thing I can do the
# don't let interrupts during main loop invoke crash handler:
suspects hook = (handling
main loop (kernel. _poll _interval)
if kernel _shell _stream. Flush(limit=1):
if kernel. Shell _stream. Flush(limit=1):
# Events to process, return control to kernel
return
except at as a matter of time ⌚
| @@ -324,7 +324,7 @@ def handle_int(etype, value, tb): | |||
| # don't let interrupts during mainloop invoke crash_handler: | |||
| sys.excepthook = handle_int | |||
| mainloop(kernel._poll_interval) | |||
| if kernel_shell_stream.flush(limit=1): | |||
| if kernel.shell_stream.flush(limit=1): | |||
| # events to process, return control to kernel | |||
| return | |||
| except: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible typo in eventloops.py : Changing kernel_shell_stream to kernel.shell_stream fixes this NameError with the MacOSX backend
Using matplotlib backend: MacOSX
ERROR:tornado.application:Exception in callback functools.partial(<function Kernel.enter_eventloop..advance_eventloop at 0x108aefe50>)
Traceback (most recent call last):
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/tornado/ioloop.py", line 741, in _run_callback
ret = callback()
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/ipykernel/kernelbase.py", line 401, in advance_eventloop
eventloop(self)
File "/Users/selasley/venvs/py39/lib/python3.9/site-packages/ipykernel/eventloops.py", line 327, in loop_cocoa
if kernel_shell_stream.flush(limit=1):
NameError: name 'kernel_shell_stream' is not defined