Request the memory usage with pss mode #936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current fix does not work. I need to look at this in more details. |
|
We will have to use memory_full_info to get PSS and since PSS is a linux only feature, we might want to check if memory_full_info is an attribute of psutil.Process() (reference), and fallback to RSS if not supported by the OS. |
|
I am developing on Mac OS, so this may the reason it is failing. I will work out the fallback solution, and would need to create a Docker image to confirm it is working fine on Linux. |
|
Closing this PR as #948 is now opened instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #935