PR: Close memory leak #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time a message is recieved on ipykernel while qt5 is activated, a `QTimer` and a `QSocketNotifier` leak. This closes the memory leak. Fixes spyder-ide/spyder#19026
jdranczewski
added a commit
to jdranczewski/ipykernel
that referenced
this pull request
Feb 3, 2024
The QTimer was introduced in d4755f6 and then changed is issue ipython#990 to close a memory leak. This change makes the code more concise by removing not instancing a QTimer object but calling the static singleShot method instead
jdranczewski
added a commit
to jdranczewski/ipykernel
that referenced
this pull request
Feb 7, 2024
The default QTimer is coarse, so can fire within +-5% of the time specified. We _need_ to fire after the delay specified so that we exit _after_ schedule_stop_aborting is scheduled. The QTimer thus needs to be a PreciseTimer. For small values of stop_on_error_timeout I found the QTimer _still_ fired up to 5ms too early, so added 10ms of delay offset. singleShot signature is inconsistent between PySide and PyQt, so we store a timer object, similar to ipython#990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a message is recieved on ipykernel while qt5 is activated, a
QTimerand aQSocketNotifierleak. This closes the memory leak.Fixes spyder-ide/spyder#19026