Remove py2-compat hack from bunch.__dir__ (#906)

Co-authored-by: Min RK <benjaminrk@gmail.com>
ipython · Nov 28, 2024 · 6d4dbac · 6d4dbac
1 parent 9522ad6
commit 6d4dbac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/tests/utils/test_bunch.py b/tests/utils/test_bunch.py
@@ -14,5 +14,8 @@ def test_bunch():
 
 def test_bunch_dir():
     b = Bunch(x=5, y=10)
-    assert "x" in dir(b)
     assert "keys" in dir(b)
+    assert "x" in dir(b)
+    assert "z" not in dir(b)
+    b.z = 15
+    assert "z" in dir(b)
diff --git a/traitlets/utils/bunch.py b/traitlets/utils/bunch.py
@@ -23,7 +23,7 @@ def __setattr__(self, key: str, value: Any) -> None:
         self.__setitem__(key, value)
 
     def __dir__(self) -> list[str]:
-        # py2-compat: can't use super because dict doesn't have __dir__
-        names = dir({})
+        names: list[str] = []
+        names.extend(super().__dir__())
         names.extend(self.keys())
         return names