Backport PR 522 to 4.3.x - Expose loaded config files, make load idempotent #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only takes a very small port of PR 341. Specifically, its a small portion of commit eaf1ae8 that introduces the List `_loaded_config_files` and returns a tuple from `load_config_file()`. This was necessary since the rest of this commit and the other 5 commits introduced API-level changes that were dependent on other changes not pertinent to a minor release.
d737580 Expose loaded config files, make load idempotent 61f25a7 Use more compatible form of copy for lists f044185 make comment more clear
Closed
|
In the absence of any other feedback, I'm going to merge this and then do a 4.3.3.dev release tomorrow or later tonight. |
|
@rmorshea - Is there anything I can help with to get 4.3.3 done? Thanks. |
|
Sorry @kevin-bates I've been really busy. Promise I'll get this done today. |
minrk
reviewed
Oct 3, 2019
| @@ -583,21 +584,26 @@ def _load_config_files(cls, basefilename, path=None, log=None, raise_config_file | |||
| " {1} has higher priority: {2}".format( | |||
| filename, loader.full_filename, json.dumps(collisions, indent=2), | |||
| )) | |||
| yield config | |||
| yield (config, loader.full_filename) | |||
There was a problem hiding this comment.
FWIW, this is a private API that was indeed used by IPython until 5.5, so this patch-release of traitlets will break IPython <5.5 (5.8 is the last supporting Python 2 and 7.8 is current). The API that called this was somewhat rarely used (mainly in IPython.embed()).
There was a problem hiding this comment.
Good information @minrk - thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 4 commits which should probably not be squashed when merged.