perf: fast path for simple default construction #639
Conversation
Benchmark results for creating a button `widgets.Button()` ------------------------------------------------ benchmark: 1 tests ----------------------------------------------- Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations ------------------------------------------------------------------------------------------------------------------- test_performance_create 2.8579 36.1314 3.3029 2.0412 3.0983 0.2583 1;22 302.7645 266 1 ------------------------------------------------------------------------------------------------------------------- After this PR, in combination with ipython/traitlets#639 ------------------------------------------------ benchmark: 1 tests ----------------------------------------------- Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations ------------------------------------------------------------------------------------------------------------------- test_performance_create 2.0695 62.7899 2.9496 3.6363 2.3238 0.8066 2;27 339.0254 290 1 ------------------------------------------------------------------------------------------------------------------- Which is a 30% performance increase.
There was a problem hiding this comment.
Given that _trait_default_generators is a private attribute (and a relatively recently added on at that) could we just change it to use the (class, name) key you're using in _simple_default? Default value creation is already complicated enough as it is, so it'd be nice if we could avoid the adding a separate cache layer if we can just fold that into an existing abstraction.
If that's not possible though I'd definitely suggest a name like _trait_default_generator_cache since that's a bit more descriptive of what the attribute does. Also, we can probably have the trait continue to use obj.trait_defaults, but have that method inspect the cache before tracing the MRO to find the default generator.
|
Replaced by #777 |
Benchmark results will come in a referring PR