Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and docs to use non-deprecated functions #778

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

jasongrout
Copy link
Member

As a followup to #306, this updates tests and docs to use the non-deprecated value_trait and per_key_traits arguments.

I also fixed two spelling typos.

jasongrout and others added 3 commits September 16, 2022 11:09
As a followup to #306, this updates tests and docs to use the non-deprecated value_trait and per_key_traits arguments.
@jasongrout
Copy link
Member Author

This fixes an issue we have in ipywidgets testing. It seems that when we import from traitlets.tests.test_traitlets import TraitTestBase, the deprecation warnings are triggered, which means we have deprecation warnings in our test suite from the traitlets codebase.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 6e91086 into main Sep 16, 2022
@blink1073 blink1073 deleted the deprecations branch September 16, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants