avoid using return t.cast
which can prevent attribute access during process teardown
#913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return t.cast(..., X)
is equivalent toreturn X # type:ignore
on the result of the expression, but (negligibly) more expensive and can cause errors e.g. preventing access to attributes during__del__
in process teardown, as seen in jupyterhub/repo2docker#1379. It's a good idea to try to avoid anything that may prevent access to attribtues. This means trying our best to keep anymodule.method
calls out of the__get__
path (note: importingfrom typing import cast
is another way to avoid this specific issue and works for methods we really do want to use in this code, but the ignores just seem better than the casts to me, anyway).Note this is only applied to
return
statements, since the type narrowing oft.cast
necessarily has no effect there other than explicitly ignoring a single type check. Other uses oft.cast
in the middle of some code for type narrowing are still totally sensible.