secrecy: add SecretString replacement; ?Sized bounds
#1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a type alias for `SecretBox<str>` to replace the previous `SecretString` type and provide a better migration path. To support this, we need to add `?Sized` bounds to `SecretBox` so `SecretBox<str>` is valid.
tony-iqlusion
force-pushed
the
secrecy/secret-string-replacement
branch
from
6a28b6a
to
fd19727
Compare
tony-iqlusion
changed the title
SecretString replacement; ?Sized boundsSecretString replacement; ?Sized bounds
Merged
|
It seems one significant change is that previously (in 0.8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type alias for
SecretBox<str>to replace the previousSecretStringtype and provide a better migration path.To support this, we need to add
?Sizedbounds toSecretBoxsoSecretBox<str>is valid.