Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip32 crate #670

Merged
merged 1 commit into from
Apr 17, 2021
Merged

bip32 crate #670

merged 1 commit into from
Apr 17, 2021

Conversation

tony-iqlusion
Copy link
Member

@tony-iqlusion tony-iqlusion commented Apr 4, 2021

Initial implementation with secp256k1 derivation support

Initial implementation with secp256k1 derivation support
@codecov-commenter
Copy link

Codecov Report

Merging #670 (9d350f2) into main (5b29c2d) will increase coverage by 5.25%.
The diff coverage is 30.90%.

❗ Current head 9d350f2 differs from pull request most recent head 185f44d. Consider uploading reports for the commit 185f44d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   46.34%   51.60%   +5.25%     
==========================================
  Files          51       58       +7     
  Lines        1944     2087     +143     
==========================================
+ Hits          901     1077     +176     
+ Misses       1043     1010      -33     
Impacted Files Coverage Δ
bip32/src/child_number.rs 0.00% <0.00%> (ø)
bip32/src/derivation_path.rs 0.00% <0.00%> (ø)
bip32/src/error.rs 0.00% <0.00%> (ø)
bip32/src/extended_secret_key.rs 0.00% <0.00%> (ø)
bip32/src/secret_key.rs 0.00% <0.00%> (ø)
hkd32/src/mnemonic/bits.rs 87.03% <ø> (+87.03%) ⬆️
hkd32/src/mnemonic/seed.rs 33.33% <ø> (+33.33%) ⬆️
hkd32/src/mnemonic/phrase.rs 72.54% <50.00%> (+72.54%) ⬆️
bip32/tests/bip39_vectors.rs 100.00% <100.00%> (ø)
bip32/tests/test_vectors.rs 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b29c2d...185f44d. Read the comment docs.

@iqlusioninc iqlusioninc deleted a comment from codecov-io Apr 17, 2021
@tony-iqlusion tony-iqlusion merged commit 3186a89 into main Apr 17, 2021
@tony-iqlusion tony-iqlusion deleted the bip32 branch April 17, 2021 14:33
/// Derivation paths within a hierarchical keyspace.
#[derive(Clone, PartialEq, Eq, Debug, Default)]
pub struct DerivationPath {
path: Vec<ChildNumber>,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: dervation paths are limited by spec to at most 256 elements, including the m. This type will allow invalid paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants