-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] IBC/ICA Support for simapp #73
base: sam/global-cap
Are you sure you want to change the base?
Conversation
x/staking/keeper/liquid_stake.go
Outdated
|
||
tokensBz, err := tokens.Marshal() | ||
if err != nil { | ||
panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
x/staking/keeper/liquid_stake.go
Outdated
|
||
var tokens sdk.Int | ||
if err := tokens.Unmarshal(tokensBz); err != nil { | ||
panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
x/staking/keeper/liquid_stake.go
Outdated
tokensBz := store.Get(types.TotalLiquidStakedTokensKey) | ||
|
||
if tokensBz == nil { | ||
panic("total liquid staked was never initialized") |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
@sampocs - I think this PR is very important, and would pair well with #71. I had some concerns about some changes you'd made affecting IBC, and this PR would let us know for sure if changes do affect IBC. I think that I am going to take a number of your PRs, and put them in #80, then make tests pass. My opinion is that we should discontinue lsm development on sdk 46 for the sake of simplicity. |
No description provided.