Skip to content

Commit

Permalink
Remove Amino encoding support (#775)
Browse files Browse the repository at this point in the history
Amino is a legacy pre-Protobuf serialization format used by early Cosmos
chains, however pretty much all of them have migrated to Protobuf by
this point.

Supporting both Amino and Protobuf is quite difficult as it completely
duplicates effort for all serialized messages, with separate `prost` and
`prost_amino` dependencies (where `prost_amino` is unmaintained) and
message types which duplicate each other for both formats. TMKMS made it
work by transcoding Protobuf to Amino back to Protobuf (for both
requests and responses).

This commit fully moves TMKMS to be natively Protobuf and Protobuf
alone.

The test suite previously only exercised the Amino functionality and has
been fully updated to use Protobufs instead.
  • Loading branch information
tony-iqlusion authored Oct 11, 2023
1 parent ccd72e9 commit 1594677
Show file tree
Hide file tree
Showing 25 changed files with 594 additions and 2,089 deletions.
69 changes: 13 additions & 56 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Tendermint Key Management System: provides isolated, optionally HSM-backed
signing key management for Tendermint applications including validators,
oracles, IBC relayers, and other transaction signing applications
"""
version = "0.12.2"
version = "0.13.0-pre"
authors = ["Tony Arcieri <tony@iqlusion.io>", "Ismail Khoffi <Ismail.Khoffi@gmail.com>"]
license = "Apache-2.0"
repository = "https://github.com/iqlusioninc/tmkms/"
Expand All @@ -17,7 +17,6 @@ rust-version = "1.65"

[dependencies]
abscissa_core = "0.7"
bytes_v0_5 = { version = "0.5", package = "bytes" }
bytes = "1"
chrono = "0.4"
clap = "4"
Expand All @@ -32,8 +31,6 @@ k256 = { version = "0.11", features = ["ecdsa", "sha256"] }
ledger = { version = "0.2", optional = true }
once_cell = "1.5"
prost = "0.11"
prost-amino = "0.6"
prost-amino-derive = "0.6"
prost-derive = "0.11"
rand_core = { version = "0.6", features = ["std"] }
rpassword = { version = "6", optional = true }
Expand All @@ -48,7 +45,7 @@ tempfile = "3"
tendermint = { version = "0.27", features = ["secp256k1"] }
tendermint-config = "0.27"
tendermint-proto = "0.27"
tendermint-p2p = { version = "0.27", features = ["amino"] }
tendermint-p2p = "0.27"
thiserror = "1"
url = { version = "2.2.2", features = ["serde"], optional = true }
uuid = { version = "1", features = ["serde"], optional = true }
Expand Down
69 changes: 0 additions & 69 deletions src/amino_types.rs

This file was deleted.

Loading

0 comments on commit 1594677

Please sign in to comment.