Rename and refactor SignableMsg::signable_bytes
#780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method name was `sign_bytes`, which as was noted in #273 is unclear to whether the resulting bytes have an appended signature. The new name indicates that the message can be signed, but has not yet been signed. Additionally, this commit does a bit of refactoring to eliminate some duplicated code within the method. Closes #273
tony-iqlusion
force-pushed
the
rename-and-refactor-signable-bytes
branch
from
c640ad4
to
2cd1966
Compare
Shella
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method name was
sign_bytes, which as was noted in #273 is unclear to whether the resulting bytes have an appended signature.The new name indicates that the message can be signed, but has not yet been signed.
Additionally, this commit does a bit of refactoring to eliminate some duplicated code within the method.
Closes #273