Enable parsing of the initial log entry & use of log entry types. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires moving these types to out of the 'audit::commands' module as it is limited to `pub (crate)` scope.
https://developers.yubico.com/YubiHSM2/Commands/Get_Log_Entries.html describes the initial audit log entry as: > When the device initializes after a reset, a log entry with all fields > set to 0xff is logged. This commit updates the serialization logic to map the initial audit log `cmd` field with value `0xff` to a `command::Code` through the `response::Code` type. We implement this as a special case in the `response::Code` to / from u8 functions.
|
This same issue was addressed in #463. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation will return an empty
LogEntriesstructure ifget_log_entriesreturns aLogEntriesthat contains an initialLogEntry. AFAIK this is caused by a failure to parse / deserialize thecmdfield of theLogEntrywhen it's set to255as this doesn't currently map to acommand::Code. The initial log entry is described in https://developers.yubico.com/YubiHSM2/Commands/Get_Log_Entries.htmlThis PR does 2 things:
LogEntriesandLogEntrystructure out of theaudit::commandsmodule (pub(crate)visibility) to theauditmodule where they're givenpubvisibility to allow use of these types by external code.from_u8andto_u8inresponse::Codeto map the value for the initial log entry value from theLogEntry::cmdfield.