Use x509-cert certificate builder

[baloo]

makes use of RustCrypto/formats#764 for generating certificates.

[baloo]

Feels like I'm redefining AlgorithmId, which is not great. (I'm considering replacing it entirely, but it's a pretty major API breakage).

[tony-iqlusion]

@baloo looks like you need to update cli/src/terminal.rs:183 too, possibly replacing into_buffer with to_der

[baloo]

yes, I haven't got time to do that yet.

[tony-iqlusion]

@baloo whoops, tried to bump the rsa version and now it's triggering a deprecation warning

[tony-iqlusion]

Also I'm about to cut rsa v0.9.0, so maybe just update to that when it's released:

RustCrypto/RSA#318

[baloo]

Sorry I missed the RSA release train (fixed the deprecation notice)

[baloo]

ran the ignored tests on a dummy yubikey:

[Running 'cargo test -- --ignored  --nocapture ']
   Compiling yubikey v0.8.0-pre.0 (/home/arthur_gautier/work/dev/yubikey.rs)
    Finished test [unoptimized + debuginfo] target(s) in 1.29s
     Running unittests src/lib.rs (target/debug/deps/yubikey-40695a15af72431a)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/integration.rs (target/debug/deps/integration-b52bb285bb799885)

running 10 tests
test test_slot_id_display ... ok
[INFO  yubikey::yubikey] connected to reader: Yubico YubiKey CCID 00 00
test test_parse_cert_from_der ... ok
test test_verify_pin ... ok
test test_get_cccid ... ok
test test_get_chuid ... ok
test test_get_config ... ok
test generate_self_signed_ec_cert ... ok
test test_list_keys ... ok
test test_read_metadata ... ok
test generate_self_signed_rsa_cert ... ok

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.92s

   Doc-tests yubikey

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

[tony-iqlusion]

Looks good. I especially like how it cleans up the dependency tree.

Seems like there's some potential refactoring possible but that seems fine as a followup to me.

Will leave a note or two inline but they're not blocking.

[tony-iqlusion]

@str4d can you take a look at this when you get a chance?

[carl-wallace]

The new function for Signer should be pub, not pub(crate). This would allow it to be used for things like generating SignedData. I'd also like to see the Attestation slot added to the list of SLOTS in piv.rs. These changes are here: carl-wallace@aef7c67. A gadget that uses this PR plus the suggested changes is here: https://github.com/carl-wallace/pbyk.

[tony-iqlusion]

@str4d unless you have any objections I'd like to merge this