Add clippy::unwrap_used lint
#515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lints for usages of `unwrap()` in the `yubikey` crate (not CLI yet). Replaces them with `?` or `expect()` as the situation warrants.
tarcieri
force-pushed
the
clippy/unwrap_used
branch
from
477656e
to
72bd18a
Compare
tony-iqlusion
commented
Aug 15, 2023
| @@ -48,6 +48,7 @@ const OBJ_CAPABILITY: u32 = 0x005f_c107; | |||
| /// - 0xff == Manufacturer ID (dummy) | |||
| /// - 0x02 == Card type (javaCard) | |||
| /// - next 14 bytes: card ID | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Turns out we don't actually use this
tony-iqlusion
commented
Aug 15, 2023
| @@ -767,6 +767,7 @@ impl RsaKeyData { | |||
| /// Generates a new RSA key data set from two randomly generated, secret, primes. | |||
| /// | |||
| /// Panics if `secret_p` or `secret_q` are invalid primes. | |||
| #[allow(clippy::unwrap_used)] // TODO(tarcieri): make fallible and handle errors | |||
There was a problem hiding this comment.
Seems like there are a lot of situations where malformed/malchosen p/q will currently cause this code to crash
tony-iqlusion
commented
Aug 15, 2023
| @@ -648,7 +647,11 @@ impl YubiKey { | |||
| return Err(Error::AuthenticationError); | |||
| } | |||
|
|
|||
| Ok(response.data()[4..12].try_into().unwrap()) | |||
There was a problem hiding this comment.
Nothing actually checked response.data().len() here so this could've potentially panicked if the response were malformed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lints for usages of
unwrap()in theyubikeycrate (not CLI yet).Replaces them with
?orexpect()as the situation warrants.