Draft: Simplify the transpilation code. #156
Open
+1,377
−615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aerylia
reviewed
Dec 18, 2024
smite
commented
Jan 8, 2025
Aerylia
reviewed
Jan 21, 2025
| Returns: | ||
| equivalent simplified quantum architecture | ||
| """ | ||
| # NOTE: assumes all qubit-resonator gates have the locus order (q, r) |
There was a problem hiding this comment.
Is that needed? We can just make it not assume the order, double check with arch.computational_resonators and arch.qubits and we don't need to bother when someone breaks convention.
added 10 commits
January 22, 2025 14:03
smite
commented
Jan 29, 2025
Comment on lines
+183
to
+185
| # TODO currently not always optimal | ||
| # assert len(c1.instructions) == 4 # prx(QB2), move(QB2, CR2), cz(QB3, CR2), cz(QB5, CR2) | ||
| assert 4 <= len(c1.instructions) <= 6 |
There was a problem hiding this comment.
The transpilation is stochastic, and will not always produce the shortest sequence (yet!).
smite
commented
Jan 29, 2025
Comment on lines
+60
to
+61
| TRANSPILER_FIX: bool = True | ||
| # TRANSPILER_FIX: bool = False |
There was a problem hiding this comment.
For now this module also contains the old transpilation code, for comparison. I will remove it before merging.
smite
commented
Jan 29, 2025
| TRUST = 'trust' | ||
| """Transpiler will keep the MOVE instructions without checking if they are correct, and add more as needed.""" | ||
| """Keep existing MOVE instructions without checking if they are correct, and add more as needed.""" | ||
| # TODO TRUST is essentially removed by the new transpiler, KEEP tries to fix any issues with existing MOVEs. |
There was a problem hiding this comment.
I think we could drop the TRUST option.
smite
commented
Jan 29, 2025
| (g, m, r, badness). Badness is the number of gates in the sequence. | ||
| Iff no sequence could be found, r is an empty string. | ||
| """ | ||
| # TODO use the lookahead to add fractional badness |
There was a problem hiding this comment.
Using the lookahead we could get a more optimal sequence.
smite
commented
Jan 29, 2025
| # are some of the locus qubits' states currently in a resonator? | ||
| if res_match := self.resonators_holding_qubits(locus): | ||
| # Some locus qubits do not hold their states, which need to be restored before applying the gate. | ||
| # FIXME As a consequence, a barrier closes a MOVE sandwich? |
There was a problem hiding this comment.
Is this behavior what we want?
smite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayoperation.