Add get_feedback_groups #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smite
reviewed
Jan 30, 2025
| self._check_authentication_errors(result) | ||
| result.raise_for_status() | ||
| try: | ||
| channel_properties = result.json() |
There was a problem hiding this comment.
No model for channel properties like we have e.g. for DynamicQuantumArchitecture?
smite
reviewed
Jan 30, 2025
Comment on lines
+928
to
+931
| for source in properties.get("fast_feedback_sources", ()): | ||
| groups.setdefault(source, set()).add(qubit) | ||
| # Merge identical groups | ||
| unique_groups: set[frozenset[str]] = {frozenset(group) for group in groups.values()} |
There was a problem hiding this comment.
What's in the fast_feedback_sources? Why do we get identical groups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to get groups of fast feedback. The method is not used by any client adapter yet, it should be called manually.
It only works with API variant V2.