Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpiler integration refactor and qiskit v1.2 support #116
base: main
Are you sure you want to change the base?
Transpiler integration refactor and qiskit v1.2 support #116
Changes from 19 commits
675533e
9fb91ee
1dd4b29
d481364
a22d8db
5ece8fa
5ab12d8
6be92bb
422eb93
1460a20
5bb86c0
a0ad923
6955de6
eb275f2
92a5641
99b8ed7
33296c1
547f0ea
b5e9e04
ea4d1bc
0f5cbe5
82fc6a3
5fd22e3
c56d86c
4206c1a
75ef5e3
f333454
836c26f
8fadfca
bf46609
be65521
177fb05
e2e52a4
0d4add2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only
scheduling_method
? What about the other *_method args?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugins are only registered as
scheduling_method
because they make assumptions about how much the circuit has been transpiled already. You can still combine them with the other transpiler args.You could make our own optimization plugin or routing plugin, but that would be exposed to the user as a string making them overwrite the existing transpiler and making it impossible to augment it with an existing pass. So they would need to defined with an existing optimization/routing pass and we need a new class for each or combination of passes we want to support. That's not maintainable.
Large diffs are not rendered by default.