Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the IQMFakeDeneb readout error value #125

Closed

Conversation

svmjdr
Copy link

@svmjdr svmjdr commented Oct 30, 2024

The ErrorProfile for the IQMFakeDeneb backend had readout fidelity numbers in place of readout error. This PR fixes that problem.

@Aerylia
Copy link
Contributor

Aerylia commented Oct 30, 2024

Can you update the CHANGELOG.rst with a description of your change and a newer version.

For example:

Version 13.17
=============

* Fixed Deneb Readout errors to closer resemble reality. Fidelities were reported as errors. `#125 <https://github.com/iqm-finland/iqm-client/pull/125>`_

If you want to make more involved changes in the future, you can use tox -e format to automatically fix the files to fit our formatting guidelines. After that, you can run tox to automatically check if the tests pass locally on your computer. Later, Github will run these tests for other supported OSs before the changes can be merged.

Copy link
Contributor

@Aerylia Aerylia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You accidentally commited a bunch of .idea files that should not be in the repository. Can you remove them?

.DS_Store Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file also needs to be removed, since this is user-specific local data.

Copy link
Contributor

@Aerylia Aerylia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Aerylia
Copy link
Contributor

Aerylia commented Oct 30, 2024

The tests are currently failing, this is because some tests were using private fields in iqm_client which they were not supposed to use and now no longer exist. This problem is fixed by another PR that is currently under review. The plan is to wait for those changes, then update the branch with latest, and then rerun the tests. This might take a few days.

@Aerylia Aerylia changed the title Fix the readout error value Fix the IQMFakeDeneb readout error value Oct 31, 2024
@Aerylia
Copy link
Contributor

Aerylia commented Oct 31, 2024

The other PRs are merged. You will have to merge main into your branch. This will create a merge conflict in the CHANGELOG.rst that you will have to resolve manually. The result should be the changelog from main with your change added as a new version, which is now version 15.1

@Aerylia
Copy link
Contributor

Aerylia commented Dec 10, 2024

I've incorporated these changes into #116 so this is obsolete.

@Aerylia Aerylia closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants