-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the IQMFakeDeneb readout error value #125
Fix the IQMFakeDeneb readout error value #125
Conversation
Can you update the CHANGELOG.rst with a description of your change and a newer version. For example:
If you want to make more involved changes in the future, you can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You accidentally commited a bunch of .idea files that should not be in the repository. Can you remove them?
.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file also needs to be removed, since this is user-specific local data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The tests are currently failing, this is because some tests were using private fields in |
The other PRs are merged. You will have to merge main into your branch. This will create a merge conflict in the CHANGELOG.rst that you will have to resolve manually. The result should be the changelog from main with your change added as a new version, which is now version 15.1 |
I've incorporated these changes into #116 so this is obsolete. |
The ErrorProfile for the IQMFakeDeneb backend had readout fidelity numbers in place of readout error. This PR fixes that problem.