Tests, build process, method kwargs handling. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CMB
commented
Apr 9, 2022
CMB
commented
- Improve detection of Python, unbreak on musl.
- define-pymethod keyword handling when length of rest list is odd.
- Add more tests.
Add a shebang to build.sh. Some environments require it. E.G., systems using musl libc won't automagically exec unknown executable types with the shell. Try using pkg-config to detect Python. Also support Python 3.10.
Mixing #!rest and #!key can lead to bugs when the length of the #!rest list is odd. Rework argument handling so that argument lists are parsed into a #!rest list and an alist of keyword pairs, rather than letting (lambda) directly handle the #!key arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.