added functionality for string.gsub in invitation whisper #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to have an invitation message that advocates for the use of inverse phrases in the /layer channel something akin to this:
Inviting you to layer 1. If you are UNHAPPY with this layer, decline my invite and type in /layer channel like "layer not 1"
strong.format doesn't natively allow you to use multiple %s values in the string so I created a helper function to also allow the use of string.gsub to look for the characters: {layer}.
This allows you to use the layer number multiple times in a whisper.
Goes alongside my other commit regarding using gsub for layer value string subsitution. I've seen 9 layers on Doomhowl (US) server before so 10+ layers could be possible. so the validation layer value assumes a 2 digit length for safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to have an invitation message that advocates for the use of inverse phrases in the /layer channel something akin to this:
*where 1 is my current layer
string.format doesn't natively allow you to use multiple %s values in the string so I created a helper function to also allow the use of string.gsub to look for the characters: {layer}.
This allows you to use the layer number multiple times in a whisper.
The helper also still checks the string for a %s and will apply a string.format if found. This maintains current compatibility with today's users' current saved template strings