Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap filename can't exceed 32 characters issue #13937 fixed. #2

Closed
wants to merge 1 commit into from

Conversation

irajneeshgupta
Copy link
Owner

Description (*)

The Sitemap filename length validation was not added , hence added \Magento\Framework\Validator\StringLength max 32 length validation for sitemap filename and it will not trim filename exceeding 32 chars.

Fixed Issues (if relevant)

  1. magento/magento2#Sitemap filename can't exceed 32 characters magento/magento2#13937: Issue title : Sitemap filename can't exceed 32 characters

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@irajneeshgupta irajneeshgupta force-pushed the irajneeshgupta-patch-13937 branch from 404b681 to 92b2394 Compare January 2, 2019 14:42
irajneeshgupta pushed a commit that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant