Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Header.php #1

Closed
wants to merge 1 commit into from
Closed

Update Header.php #1

wants to merge 1 commit into from

Conversation

iranimij
Copy link
Owner

@iranimij iranimij commented Nov 21, 2023 •
edited
Loading

check if the welcome field is not null and then we try to scape it

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes When the welcome message is empty we face an error in front-end magento/magento2#38209

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@iranimij
Update Header.php
79c0ab0 
check if the welcome field is not null and then we try to scape it
@iranimij iranimij closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the welcome message is empty we face an error in front-end
1 participant
@iranimij