Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new features from August API Changelog #19

Merged
merged 2 commits into from
Aug 20, 2015
Merged

Added new features from August API Changelog #19

merged 2 commits into from
Aug 20, 2015

Conversation

jonnywilliamson
Copy link
Contributor

As from the latest Official API changelog

August 15, 2015
Added new type Voice and new method sendVoice for sending voice messages.
Earlier Audio and sendAudio should now be used for sending music files. Telegram clients will show such files in the in-app music player. If you were using sendAudio for your bot to send voice messages, please use sendVoice instead.
Added optional fields performer, title to the Audio object and sendAudio method.
Added optional field voice to the Message object.

This PR adds all new features in the above changelog to the the bot sdk.

irazasyed added a commit that referenced this pull request Aug 20, 2015
Added new features from August API Changelog
@irazasyed irazasyed merged commit 38b776b into irazasyed:master Aug 20, 2015
@irazasyed
Copy link
Owner

Thanks @jonnywilliamson for the PR. This is a breaking change though. Will tag soon after i verify a few more things that seems to have been changed.

@jonnywilliamson
Copy link
Contributor Author

@irazasyed What other things did I miss that had changed ? Just curious!

@irazasyed
Copy link
Owner

I would want to keep the param order as per the official docs and that's what is being followed in all other functions mostly. Because if we change the order, then the users would have to start going through this library's own documentation and end up confusing or learning twice which i feel is unnecessary and the whole point of this library was to make things easier, not the other way around.

As far as other things are concerned, I thought there are other things we missed but didn't find any (Already implemented actually). So left that for now. Since this is a major change and would require me to bump to v1.0.0 i was thinking to do that with the command handler system, So it would make sense we have a new feature with some major changes, Would give a good reason for people to upgrade :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants