Don't run tcp listener if tcp.listen not configured #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russss
approved these changes
Jan 16, 2024
edwinbalani
added a commit
to edwinbalani/irccat
that referenced
this pull request
Mar 31, 2024
After 60526f6 (irccloud#31), `irccat.tcp.Run(irccat.irc)` is called (if the config calls for it) before, rather than after, `irccat.connectIRC()`, which changes `irccat.irc` away from a nil pointer in the first place. This pointer is copied into the `irc` field of a TCPListener `l` by `irccat.tcp.Run()`. A panic won't actually happen until the TCP listener handles its first message, if it ever comes, and in doing so passes the nil pointer further down to `dispatcher.Send(l.irc, ...)`. To fix, bring the call to `irccat.connectIRC()` forward again, to before any listener setup is done at all. This probably makes sense stylistically too.
russss
pushed a commit
that referenced
this pull request
Apr 3, 2024
After 60526f6 (#31), `irccat.tcp.Run(irccat.irc)` is called (if the config calls for it) before, rather than after, `irccat.connectIRC()`, which changes `irccat.irc` away from a nil pointer in the first place. This pointer is copied into the `irc` field of a TCPListener `l` by `irccat.tcp.Run()`. A panic won't actually happen until the TCP listener handles its first message, if it ever comes, and in doing so passes the nil pointer further down to `dispatcher.Send(l.irc, ...)`. To fix, bring the call to `irccat.connectIRC()` forward again, to before any listener setup is done at all. This probably makes sense stylistically too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the TCP listener would listen on a random port if no
tcp.listenwas configured.