-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXTJWT command for integrating external web services #547
base: master
Are you sure you want to change the base?
Conversation
Co-Authored-By: Kyle Fuller <kyle@fuller.li>
Co-Authored-By: Sadie Powell <sadie@witchery.services>
Having the verify url within the token would encourage implementations to use the url without verifying its trusted, allowing the spoofing of tokens. The verify url should be a pre-shared component for trust.
Reasoning behind removing the Having the verify url within the token would encourage implementations to use the url without verifying its trusted, allowing the spoofing of tokens. The verify url should be a pre-shared component for trust, just like the key would be pre-shared. With the url having the advantage of not actually sharing the key, so that the host of the third party service could not actually generated trusted tokens. |
Our implementation is updated to match the new pull request. https://github.com/inspircd/inspircd-contrib/blob/master/4/m_ircv3_extjwt.cpp |
As prawnsalad has stepped back from IRC development and I have taken over Kiwi IRC development. I cannot allow this ircv3 specification to be abandoned as Kiwi IRC uses it for quite a few plugins. (jitsi conferencing, file uploads, account avatar uploads)
So I have also forked #341 and updated based on comments from within the previous pull-request.