Ingress Rewrite Changes #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed url prefix in react app and basename in react router
|
Please do that change directly from that repo. When repo is forked, secrets are not being replicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Ingress Fitness UI --
Added rewrite in annotations to rewrite to added /fitness prefix
Changed path
Changed pathType to ImplementationSpecific to rewrite to /fitness
-- React App --
In App.tsx added basename in react router ("/fitness")
in package.json added homepage ("/fitness") for build to properly serve static assets
-- Ingress Fitness Server --
Added rewrite to to /fitness/api -> server routes haven't been changed, only rewrite has been added in ingress.
Ingress has been changed similarly to fitness ui ingress