[boo] introduce op registry #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftynse
force-pushed
the
users/ftynse/generalize
branch
2 times, most recently
from
4295d73 to
8e0af50
Compare
ftynse
force-pushed
the
users/ftynse/generalize
branch
from
8e0af50 to
03131f3
Compare
rkayaith
reviewed
Jul 23, 2025
zjgarvey
reviewed
Jul 23, 2025
Introduce a registry class handling metadata classes for BOO ops. This automatically traverses the ops available in `op_exports` and registers them with a singleton registry class that can be later queried using the op "name". This name is supposed to be a unique string that cannot appear in the CLI syntax of another op. This is suboptimal and is difficult to ensure statically without a formal syntax, but will work as long as the syntax mirrors that of MIOpen driver. This allows a major refactoring of op exports that can now be aggregated in a single directory and share generic implementation for benchmarking, numerics, and cache prepopulation. Note that most of the implementation was refactored previously leaing only shims in specific op exports. Most of this commit is moving code around. Cache pre-population test is updated to exercise the multi-op parser and dispatch. Driver files are updated to use the registry instead of directly loading individual ops. READMEs are consolidated into the top-level user-facing document and developer-oriented document in the `driver` directory. Signed-off-by: Alex Zinenko <git@ozinenko.com>
It is broken at IREE level Signed-off-by: Alex Zinenko <git@ozinenko.com>
Signed-off-by: Alex Zinenko <git@ozinenko.com>
ftynse
force-pushed
the
users/ftynse/generalize
branch
from
48659c3 to
6e48c00
Compare
Signed-off-by: Alex Zinenko <git@ozinenko.com>
|
PTAL, I'll move gemm separately so we don't have more merge conflicts |
rkayaith
approved these changes
Jul 23, 2025
rkayaith
reviewed
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a registry class handling metadata classes for BOO ops. This automatically traverses the ops available in
op_exportsand registers them with a singleton registry class that can be later queried using the op "name". This name is supposed to be a unique string that cannot appear in the CLI syntax of another op. This is suboptimal and is difficult to ensure statically without a formal syntax, but will work as long as the syntax mirrors that of MIOpen driver.