[TKW] Implement broadcastOp class, lowering and insertion #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikonenfnu
force-pushed
the
broadcastUpstream
branch
2 times, most recently
from
7d2ff0b
to
ab09ba6
Compare
harsh-nod
requested changes
Sep 28, 2024
raikonenfnu
force-pushed
the
broadcastUpstream
branch
from
2ac0e47
to
3d9db14
Compare
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
raikonenfnu
force-pushed
the
broadcastUpstream
branch
from
3d9db14
to
5e3acb4
Compare
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
harsh-nod
approved these changes
Oct 4, 2024
| if lhs_dim_set.isdisjoint(rhs_dim_set): | ||
| raise ValueError( | ||
| "BinaryPyOp requires lhs and rhs shape to be at least broadcastable." | ||
| ) |
There was a problem hiding this comment.
Looks good. I would just add a comment that this is now a binary py op which supports broadcasting semantics.
Signed-off-by: Stanley Winata <stanley.winata@amd.com>
stellaraccident
pushed a commit
that referenced
this pull request
Oct 13, 2024
Motivation of this PR is to be able to codegen/lower broadcast properly. With that in mind, we implemented these things: 1. BroadcastOp class, op and lowering, to represent and store broadcasting information. Mostly S.T we can query target shape information and the source operand of broadcast. 2. Treat broadcast-add as an index conflict and handle it by emitting broadcastOp. --------- Signed-off-by: Stanley Winata <stanley.winata@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation of this PR is to be able to codegen/lower broadcast properly. With that in mind, we implemented these things: