Add padding to reduce shared memory bank conflicts #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds padding to shared memory allocations to minimize bank conflicts. Signed-off-by: Harsh Menon <harsh@nod-labs.com>
harsh-nod
requested review from
Hardcode84,
martin-luecke,
raikonenfnu and
erman-gurses
raikonenfnu
reviewed
Oct 4, 2024
| would involve swizzling of the shared memory access patterns. | ||
| """ | ||
| padding = 64 // dtype.bitwidth() | ||
| return tuple( |
There was a problem hiding this comment.
what if it's already aligned?
There was a problem hiding this comment.
For this approach, we just apply a blanket padding value that is independent of whether the shape is aligned or not. We could also making this a tuning parameter to see which value gives the best performance for a given shape.
raikonenfnu
reviewed
Oct 4, 2024
| """ | ||
| padding = 64 // dtype.bitwidth() | ||
| return tuple( | ||
| value + padding if i == len(shape) - 1 else value |
There was a problem hiding this comment.
can we do something like shape[-1] += padding?
There was a problem hiding this comment.
Shape is a tuple so unfortunately not.
raikonenfnu
reviewed
Oct 4, 2024
raikonenfnu
approved these changes
Oct 4, 2024
stellaraccident
pushed a commit
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds padding to shared memory allocations
to minimize bank conflicts.