Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test experiments #224

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Perf test experiments #224

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f4e69d
perf test experiments
Hardcode84 Oct 17, 2024
3aa7a95
test
Hardcode84 Oct 17, 2024
eee0ffc
test
Hardcode84 Oct 17, 2024
f7064cc
test
Hardcode84 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/perf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
name: PERF

on:
workflow_dispatch:
pull_request:
push:
branches:
- main
issue_comment:
types: [created, edited]
schedule:
- cron: '30 5 * * *'

Expand All @@ -19,7 +16,8 @@ concurrency:

jobs:
test:
name: "Unit Tests and Type Checking"
name: "Perf Tests"
if: ${{ github.event.issue.pull_request }} && contains(github.event.comment.body, '/turbine_run_perf')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to look for a label being applied or validate the author of the comment somehow. This looks like any GitHub user (project member or not) could trigger the workflow by adding this comment. That increases the surface area for malicious behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doesn't work anyway yet :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just probably create separate personal repo and experiment on it first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/iree-org/iree/blob/7d60397cbe62e8563a36ec286c41aa40d7e4e58d/.github/workflows/benchmark_trigger.yml might also be useful to reference (I'm sure there are other good references in other github projects, but that's what we used in iree-org/iree for a while)

strategy:
fail-fast: false
matrix:
Expand Down
Loading