Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added readme to the aot_mlp example #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xintin
Copy link

@xintin xintin commented Nov 13, 2024

This pull request includes the following main changes:

  1. Added assertions to the aot_mlp example.
  2. Replaced print statements with loggers.
  3. Added requirements.txt for the aot_mlp example.
  4. Added a README.md file for the aot_mlp example.

Signed-off-by: Gaurav Verma <vermagaurav9408@gmail.com>
Signed-off-by: xintin <vermagaurav9408@gmail.com>
@xintin xintin force-pushed the xintin/added_readme_aot_mlp branch from f44920b to 34f2379 Compare November 13, 2024 06:29
@ScottTodd ScottTodd self-requested a review November 20, 2024 02:15
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry this went unnoticed for a few days. Just a few lint checks to appease and then we can merge this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit link checks found a few minor style issues in this file and the README: https://github.com/iree-org/iree-turbine/actions/runs/11811883913/job/33237529472?pr=266

Docs: https://github.com/iree-org/iree-turbine?tab=readme-ov-file#optional-pre-commits-and-developer-settings

If you could fix those, that would be great. A maintainer could also push those fixes for you.

@@ -0,0 +1,4 @@
numpy
torch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to suggest https://github.com/iree-org/iree-turbine/tree/main?tab=readme-ov-file#install-pytorch-for-your-system for some users rather than the stock torch requirement, at least as a note in the README ahead of the pip install -r requirements.txt. Installing the CPU torch wheel is much faster than the default (that includes tons of CUDA deps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants