Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to depend on iree 3.0.0 packages. #275

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

ScottTodd
Copy link
Member

See the release tracker at iree-org/iree#19063.

@ScottTodd ScottTodd marked this pull request as ready for review November 15, 2024 17:29
@ScottTodd ScottTodd requested a review from marbre November 15, 2024 17:29
@marbre
Copy link
Member

marbre commented Nov 15, 2024

Seems there are some failures which might be due to the update :/

@ScottTodd
Copy link
Member Author

Seems there are some failures which might be due to the update :/

Ack. Fixed a few but looks like there are more.

@ScottTodd
Copy link
Member Author

Updated to latest stable IREE 3.0.0. PTAL?

@ScottTodd ScottTodd merged commit 583004f into iree-org:main Nov 18, 2024
7 checks passed
@ScottTodd ScottTodd deleted the version-3.0.0 branch November 18, 2024 19:10
@marbre
Copy link
Member

marbre commented Nov 18, 2024

I can confirm that the CI on main pulls in the iree-base-{compiler,runtime} packages with version 3.0.0. However, I also noticed https://github.com/iree-org/iree-turbine/actions/runs/11898714760/job/33155792634#step:5:86. Not necessarily something we need to fix now (as a release is manually build) but seems worth to at least fill an issue. WDYT?

@ScottTodd
Copy link
Member Author

I can confirm that the CI on main pulls in the iree-base-{compiler,runtime} packages with version 3.0.0. However, I also noticed https://github.com/iree-org/iree-turbine/actions/runs/11898714760/job/33155792634#step:5:86. Not necessarily something we need to fix now (as a release is manually build) but seems worth to at least fill an issue. WDYT?

Yeah we can clean that up. The build_release.py script mandates a --package-version, and the workflow has it hardcoded to 2.5.0.dev:

parser.add_argument("--package-version", help="Version to use", required=True)
- name: Build Release Wheels
run: ./build_tools/build_release.py --package-version 2.5.0.dev

@marbre
Copy link
Member

marbre commented Nov 18, 2024

Okay, let's handle it in a follow up. I assume we want to push nightly releases via GH anyway?

@ScottTodd
Copy link
Member Author

Yeah we can start publishing nightly packages via GH. I'll file an issue in IREE to scrape other sources when building the index at https://iree.dev/pip-release-links.html, so we can have a single --find-links --pre that gets all of our packages.

@ScottTodd
Copy link
Member Author

Filed iree-org/iree#19193 for the consolidated nightly release index page

@ScottTodd
Copy link
Member Author

Fixing the --package-version 2.5.0.dev in #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants