Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TKW] Propagate dynamic mapping index #320

Merged
merged 10 commits into from
Dec 11, 2024
Merged

[TKW] Propagate dynamic mapping index #320

merged 10 commits into from
Dec 11, 2024

Conversation

Hardcode84
Copy link
Contributor

No description provided.

@Hardcode84
set_derived_index
4f0266b 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
write test
c0fe09c 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
fix test
23a4004 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
fix
0afd7cb 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
test
f74232a 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
test
c69def6 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
test
dea0c2d 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
test
3802a64 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84 Hardcode84 changed the title [WIP] Propagate dynamic mapping index [TKW] Propagate dynamic mapping index Dec 9, 2024
@Hardcode84 Hardcode84 marked this pull request as ready for review December 9, 2024 14:45
harsh-nod
harsh-nod requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@harsh-nod harsh-nod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few comments. I think the big thing missing is some lit tests, but should be good to land after that.

iree/turbine/kernel/wave/index_sequence_analysis.py Show resolved Hide resolved
iree/turbine/kernel/_support/indexing.py Show resolved Hide resolved
iree/turbine/kernel/ops/wave_ops.py Show resolved Hide resolved
iree/turbine/kernel/ops/wave_ops.py Show resolved Hide resolved
iree/turbine/kernel/wave/index_sequence_analysis.py Show resolved Hide resolved
iree/turbine/kernel/wave/index_sequence_analysis.py Show resolved Hide resolved
@Hardcode84
add lit test
db3b778 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
@Hardcode84
add comments
919070c 
Signed-off-by: Ivan Butygin <ivan.butygin@gmail.com>
harsh-nod
harsh-nod approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@harsh-nod harsh-nod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@Hardcode84 Hardcode84 merged commit 6075d0d into iree-org:main Dec 11, 2024
10 checks passed
@Hardcode84 Hardcode84 deleted the dyn-mapping-index branch December 11, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-amd harsh-amd harsh-amd left review comments

@harsh-nod harsh-nod harsh-nod approved these changes

@martin-luecke martin-luecke Awaiting requested review from martin-luecke

@raikonenfnu raikonenfnu Awaiting requested review from raikonenfnu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hardcode84 @harsh-nod @harsh-amd