[TKW] Avoid nested multiprocessing.Pool usage
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-nod
reviewed
Dec 13, 2024
| @@ -229,7 +230,11 @@ def all_pairs_longest_paths( | |||
| # Parallel implementation | |||
| for k in range(N): | |||
| func = partial(all_pairs_longest_path_parallel, N, D, k) | |||
| results = pool.map(func, range(N)) | |||
| if pool is not None: | |||
There was a problem hiding this comment.
Can you add a comment explaining what would be the right way to do this?
harsh-nod
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processes created by
multiprocessing.Poolhavedaemonflag which forbids to create child processes (e.g. from nestedmultiprocessing.Pool). Fallback to single-process compilation in this case. This fixes a crash when compilation itself is called from insidemultiprocessing.Poolprocesses.