Remove thread shape analysis #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Menon <harsh@nod-labs.com>
raikonenfnu
reviewed
Dec 15, 2024
raikonenfnu
reviewed
Dec 15, 2024
raikonenfnu
reviewed
Dec 15, 2024
raikonenfnu
reviewed
Dec 15, 2024
| continue | ||
| if lhs_dim != rhs_dim: | ||
| # If the dimensions don't agree, we can still do this broadcast only if | ||
| # this has a reduce op in its backward slice along the broadcasting dimension, |
There was a problem hiding this comment.
Can w get an IR/visual example for this :)
There was a problem hiding this comment.
Sure will add it into the comments.
There was a problem hiding this comment.
okay I simplified this a bit. Can you take another look? I don't need to check for read/reduce ops in backward slice. Its enough to just do checks on the shapes.
raikonenfnu
reviewed
Dec 15, 2024
raikonenfnu
reviewed
Dec 15, 2024
Signed-off-by: Harsh Menon <harsh@nod-labs.com>
raikonenfnu
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.