addreess comments

iree-org · Jun 7, 2024 · bf8cfce · bf8cfce
1 parent 997815b
commit bf8cfce
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/compiler/src/iree/compiler/Codegen/LLVMCPU/test/select_x86_64_lowering_strategy.mlir b/compiler/src/iree/compiler/Codegen/LLVMCPU/test/select_x86_64_lowering_strategy.mlir
@@ -1613,7 +1613,7 @@ module {
     return
   }
 }
-//  CHECK-DAG: #[[CONFIG:.+]] = #iree_codegen.lowering_config<tile_sizes = {{\[}}[20, 64, 0, 0, 0], [20, 32, 0, 0, 0]]>
+//  CHECK-DAG: #[[CONFIG:.+]] = #iree_codegen.lowering_config<tile_sizes = {{\[}}[20, 64, 0, 0, 64], [20, 32, 0, 0, 32], [0, 0, 0, 32, 0]]>
 //  CHECK-DAG: #[[TRANSLATION:.+]] = #iree_codegen.translation_info<CPULinalgExtTileAndVectorize>
 //      CHECK: func.func @attention()
 // CHECK-SAME:     translation_info = #[[TRANSLATION]]

diff --git a/compiler/src/iree/compiler/Dialect/LinalgExt/TransformExtensions/LinalgExtExtensionsOps.cpp b/compiler/src/iree/compiler/Dialect/LinalgExt/TransformExtensions/LinalgExtExtensionsOps.cpp
@@ -57,9 +57,7 @@ DiagnosedSilenceableFailure LinalgExt::ConvertToOnlineAttention::applyToOne(
     transform::TransformState &state) {
   SmallVector<Operation *> ops;
   LinalgExt::convertToOnlineAttention(attentionOp, ops, rewriter);
-  for (auto op : ops) {
-    results.push_back(op);
-  }
+  llvm::append_range(results, ops);
   return DiagnosedSilenceableFailure::success();
 }
 

diff --git a/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp b/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
@@ -143,7 +143,7 @@ AffineMap dropResultsContainingDims(AffineMap map, ArrayRef<int64_t> dims) {
     }
   }
 
-  // Iterate in reverse to preserve indexes to drop.
+  // Iterate in reverse to preserve indices to drop.
   for (int result : llvm::reverse(resultsToDrop)) {
     map = map.dropResult(result);
   }

diff --git a/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/TileAttention.cpp b/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/TileAttention.cpp
@@ -159,8 +159,8 @@ struct TileAttentionPass : public TileAttentionBase<TileAttentionPass> {
   void runOnOperation() override;
 };
 
-struct ConvertAttentionToOnlineAttentionPass
-    : public ConvertAttentionToOnlineAttentionBase<
+struct ConvertAttentionToOnlineAttentionPass final
+    : ConvertAttentionToOnlineAttentionBase<
           ConvertAttentionToOnlineAttentionPass> {
   void getDependentDialects(DialectRegistry &registry) const override {
     registry