Make iree.compiler.api.Output.map_memory() retain its backing reference. #15975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the precise structure of the code and state of the garbage collector, this could cause very long-range crashes that appeared to have nothing to do with the allocation mechanism. * Adds a retaining finalizer to the map_memory() pointer return. * Adds a test that grinds two patterns that I found which produce bugs. * Fixes VmModule::WrapBuffer to close over its Py_buffer. I noticed this when auditing and it is subtly wrong: it will not break in this specific case but in cases where the backing memory has to be copied or re-organized, it could result in a use-after-free. Fixes #15407
benvanik
approved these changes
Dec 19, 2023
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the precise structure of the code and state of the garbage collector, this could cause very long-range crashes that appeared to have nothing to do with the allocation mechanism.
Fixes #15407