-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and samples to use latest iree-turbine. #19054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
added
documentation
✏️ Improvements or additions to documentation
infrastructure
Relating to build systems, CI, or testing
integrations/pytorch
PyTorch integration work
labels
Nov 6, 2024
marbre
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Scott, this is a great improvement!
vinayakdsci
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
JamesMBartlett
pushed a commit
to gimletlabs/iree
that referenced
this pull request
Nov 8, 2024
This adapts docs and samples to https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0. * Switched from `import shark_turbine.aot as aot` to `import iree.turbine.aot as aot` (see also iree-org/iree-turbine#28). * Redirected notes from `/RELEASING.md` to https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md. The release process is changing now with iree-org#18938 and I'll want to fold the notes there in to https://iree.dev/developers/general/release-management/ instead. * Re-ran some Colab notebooks and adapted to the latest changes across projects. Note that the https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample still has code using `@aot.jittable`, so I have re-opened iree-org#18564 to migrate it. I spent some time trying to update it but wasn't sure how to demonstrate dynamic shapes using the "modern canonical usage" effectively. * This fixes the recent test failures: https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934. Test run: https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This adapts docs and samples to https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0. * Switched from `import shark_turbine.aot as aot` to `import iree.turbine.aot as aot` (see also iree-org/iree-turbine#28). * Redirected notes from `/RELEASING.md` to https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md. The release process is changing now with iree-org#18938 and I'll want to fold the notes there in to https://iree.dev/developers/general/release-management/ instead. * Re-ran some Colab notebooks and adapted to the latest changes across projects. Note that the https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample still has code using `@aot.jittable`, so I have re-opened iree-org#18564 to migrate it. I spent some time trying to update it but wasn't sure how to demonstrate dynamic shapes using the "modern canonical usage" effectively. * This fixes the recent test failures: https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934. Test run: https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This adapts docs and samples to https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0. * Switched from `import shark_turbine.aot as aot` to `import iree.turbine.aot as aot` (see also iree-org/iree-turbine#28). * Redirected notes from `/RELEASING.md` to https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md. The release process is changing now with iree-org#18938 and I'll want to fold the notes there in to https://iree.dev/developers/general/release-management/ instead. * Re-ran some Colab notebooks and adapted to the latest changes across projects. Note that the https://github.com/iree-org/iree/tree/main/samples/dynamic_shapes sample still has code using `@aot.jittable`, so I have re-opened iree-org#18564 to migrate it. I spent some time trying to update it but wasn't sure how to demonstrate dynamic shapes using the "modern canonical usage" effectively. * This fixes the recent test failures: https://github.com/iree-org/iree/actions/runs/11697207429/job/32575551934. Test run: https://github.com/ScottTodd/iree/actions/runs/11713816651/job/32627295562 Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
✏️ Improvements or additions to documentation
infrastructure
Relating to build systems, CI, or testing
integrations/pytorch
PyTorch integration work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts docs and samples to https://github.com/iree-org/iree-turbine/releases/tag/v2.5.0.
import shark_turbine.aot as aot
toimport iree.turbine.aot as aot
(see also Complete migration from shark_turbine to iree/turbine namespace iree-turbine#28)./RELEASING.md
to https://github.com/iree-org/iree-turbine/blob/main/docs/releasing.md. The release process is changing now with [RFC] New versioning scheme for IREE Python packages #18938 and I'll want to fold the notes there in to https://iree.dev/developers/general/release-management/ instead.@aot.jittable
, so I have re-opened Docs: update torch export docs with modern canonical usage #18564 to migrate it. I spent some time trying to update it but wasn't sure how to demonstrate dynamic shapes using the "modern canonical usage" effectively.