[DispatchCreation] Add CSE before canonicalization of flow.dispatch.workgroups
#19178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of contractions by default due to regressions. This PR fixes the regressions and turns them on again. Fixes are: 1) If the original code had multiple dynamic dimensions, where one or more of those are not blocked, those need to be accounted for in the `expand_shape` generated. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
|
Depends on #19171 . Only review the last commit. |
…workgroups`. The real change in this PR is to add CSE before canonicalization so that operands of `flow.dispatch.workgroups` can be better de-duped. Since this needed a pipeline test, noticed the pipeline test existed in Flow and called the global optimization, dispatch creation and flow pipelines. This PR moves the test to dispatch creation and only tests that pipeline. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
MaheshRavishankar
force-pushed
the
block_dynamic_dims_cse
branch
from
2cd306a to
3d95b4d
Compare
hanhanW
approved these changes
Nov 18, 2024
Potentially, but Flow does not actually form dispatches now.. So I was mostly looking for dispatch formation pipeline tests. |
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…workgroups` (iree-org#19178) The real change in this PR is to add CSE before canonicalization so that operands of `flow.dispatch.workgroups` can be better de-duped. Since this needed a pipeline test, noticed the pipeline test existed in Flow and called the global optimization, dispatch creation and flow pipelines. This PR moves the test to dispatch creation and only tests that pipeline. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…workgroups` (iree-org#19178) The real change in this PR is to add CSE before canonicalization so that operands of `flow.dispatch.workgroups` can be better de-duped. Since this needed a pipeline test, noticed the pipeline test existed in Flow and called the global optimization, dispatch creation and flow pipelines. This PR moves the test to dispatch creation and only tests that pipeline. Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real change in this PR is to add CSE before canonicalization so
that operands of
flow.dispatch.workgroupscan be better de-duped.Since this needed a pipeline test, noticed the pipeline test existed
in Flow and called the global optimization, dispatch creation and flow
pipelines. This PR moves the test to dispatch creation and only tests
that pipeline.
Signed-off-by: MaheshRavishankar mahesh.ravishankar@gmail.com